Fix "Generate artifacts" stage in CI #1521
Conversation
There was a problem hiding this comment.
@dgburr I see the "Generate artifacts" stage is still failing? 🤔
Is this still a work in progress?
|
There was a problem hiding this comment.
Thanks @dgburr
I'm wondering about the formatting differences in rust during the release process, do you know if there is a version mismatch in what we are using during release? I don't have much knowledge about it and wondering if you can help me out on this.
|
@dgburr i don't understand how my commit could have broken the build? I don't care if you revert it but all it does it some cosmetic formatting in the rust code reverting a previous lint fix i had written and does a minor bump of a rust dependency. There is something fishy about how this project is being built etc vs ci. That said. whatever gets it working is a-ok by me. |
@pcrumley: My previous statement was incorrect - it wasn't your commit which broke the build, but it was 0814cbc, which resulted in the .toml files and rust formatting to get overwritten with versions derived from the "bad" template. |
Description
Fix the "Generate artifacts" stage in CI by updating the templates used to generate https://github.com/swift-nav/libsbp/blob/master/rust/sbp/Cargo.toml and https://github.com/swift-nav/libsbp/blob/master/rust/sbp2json/Cargo.toml so that they will produce files which are equivalent to those already committed to git (in #1505).
This PR reverts ddf6363 (which was a previous attempt to fix this issue) as well as part of 0814cbc (which "updated" the .toml files to the incorrect versions).
API compatibility
Does this change introduce a API compatibility risk?
No
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
N/A
JIRA Reference
https://swift-nav.atlassian.net/browse/BOARD-XXXX